initial version #1
Conversation
| import java.util.concurrent.atomic.AtomicReference; | ||
| import java.util.function.BiConsumer; | ||
|
|
||
| public class Entry { |
| import java.io.FileNotFoundException; | ||
| import java.util.Map; | ||
|
|
||
| public class InterpreterSettingsConfig { |
There was a problem hiding this comment.
class&variables in getConfig could be final.
getConfig could be renamed to just config().
| } | ||
|
|
||
| final String propertieskey = "properties"; | ||
| if (!sparkObject.containsKey(propertieskey)) { |
There was a problem hiding this comment.
could make a separate validation object for these like in nlf_01. perhaps for another issue
| import java.util.concurrent.atomic.AtomicReference; | ||
| import java.util.function.BiConsumer; | ||
|
|
||
| public final class Entry { |
There was a problem hiding this comment.
Perhaps there could be a "DPLQuery" object that takes the query as a ctor argument and returns the result dataset. Then "Entry" could handle the arguments and initializing objects and printing the dataset to console/file.
There was a problem hiding this comment.
how does this differ from current?
final DPLExecutorResult executorResult = dplExecutor
.interpret(batchHandler, sparkSession, queryId, noteId, paragraphId, lines);
takes the query and the intialized objects and returns the result via the batchHandler. Entry is atm responsible for print and initialization.
There was a problem hiding this comment.
I was thinking it would pretty much contain the lines 90-118, and return the String that is currently updated with the AtomicReference. But in the end I suppose it doesn't differ all that much from the current implementation.
2 participants
Description
Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality